Repository navigation
Conversation
glichtner
added a commit
to Dissolve-E/awmf-ig
that referenced
this pull request
Nov 3, 2026
publish-version.sh runs the IG Publisher itself and did not get the SUSHI from install-sushi.sh, so a release build would use the released SUSHI and lose the classifier profile again (FHIR/sushi#1653). It now puts it first on PATH after the dependency builds, as run-ig-publisher.sh does. The -go-publish rebuild runs in the same process and uses it too, so both builds report the same QA counts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a new slice constrains an extension copied from the slicing entry, SUSHI can omit the extension's profile from the differential. The snapshot generator then sees a generic
Extensionand loses its specific value type.Example
Expected: the differential for
Patient.link:seeAlso.extension:kindincludestype.code = Extensionandtype.profile = http://hl7.org/fhir/us/minimal/StructureDefinition/LinkKind, alongsidemin = 1.Actual before this PR: the element contains only
id,path,sliceNameandmin. The Java snapshot generator consequently reports “has no profile and no fixed url” and cannot resolve the constraint onvalue[x].coding.Cause
SUSHI copies the extension slice into its working snapshot but retains its original differential baseline. Its identifying profile is therefore treated as unchanged and omitted, even though the extension is being declared at a new location.
Testing instructions
The FSH above is the input to
declares the extension profile in a new sliceintest/export/InheritedExtensionSlice.test.ts, using the same FHIR version and canonical as the test configuration.npm test -- --runInBand test/export/InheritedExtensionSlice.test.tsAll eight exporter cases and all 3,586 suite tests pass; TypeScript and ESLint pass.
The original regression from #1609 in
test/export/StructureDefinitionExporter.test.tsremains unchanged and passes. It asserts that an untouched inherited extension is omitted and the child differential contains exactly the three expected elements.Related issues
PR #1609 introduced the
_original.idassignment to prevent copied, unchanged extensions from appearing in a child differential solely because their IDs changed. This PR preserves that protection by handling ID-only relocation of the same extension inhasDiff(), instead of overwriting the original ID incloneChildren().Keeping the original ID allows
calculateDiff()to recognize copies and include their identifying type/profile when the extension or its descendants are constrained. Unchanged copies remain omitted, and extension slices already declared in a parent profile continue to emit only their changed properties.